taiki-e/install-action
1
0
Fork 0
mirror of https://github.com/taiki-e/install-action.git synced 2026-05-10 11:31:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

codegen: Ignore clippy::literal_string_with_formatting_args lint

Browse Source 
```
error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:142:65
    |
142 | ...                   d.url = Some(template.url.replace("${version}", version));
    |                                                           ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args
    = note: `-D clippy::literal-string-with-formatting-args` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::literal_string_with_formatting_args)]`

error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:146:64
    |
146 | ...                   .map(|s| s.map(|s| s.replace("${version}", version)));
    |                                                      ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args

error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:567:73
    |
567 |             let template_url = d.url.take().unwrap().replace(version, "${version}");
    |                                                                         ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args

error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:568:84
    |
568 |             let template_bin = d.bin.take().map(|s| s.map(|s| s.replace(version, "${version}")));
    |                                                                                    ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args

error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:615:29
    |
615 |     let mut s = s.replace("${package}", package).replace("${tool}", package);
    |                             ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args

error: this looks like a formatting argument but it is not part of a formatting macro
   --> tools/codegen/src/main.rs:625:25
    |
625 |         s = s.replace("${version}", version);
    |                         ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args
```
This commit is contained in:
Taiki Endo
2024-12-27 10:57:03 +09:00
parent acd2589197
commit 8cec5c3000
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/codegen/src/main.rs
View File

@@ -137,6 +137,7 @@ fn main() -> Result<()> {
}; };
let version = &*k.0.to_string(); let version = &*k.0.to_string();
if let Some(template) = &manifests.template { if let Some(template) = &manifests.template {
#[allow(clippy::literal_string_with_formatting_args)]
for (platform, d) in &mut manifest.download_info { for (platform, d) in &mut manifest.download_info {
let template = &template.download_info[platform]; let template = &template.download_info[platform];
d.url = Some(template.url.replace("${version}", version)); d.url = Some(template.url.replace("${version}", version));
@@ -563,6 +564,7 @@ fn main() -> Result<()> {
}; };
let version = &*version.0.to_string(); let version = &*version.0.to_string();
let t = template.as_mut().unwrap(); let t = template.as_mut().unwrap();
#[allow(clippy::literal_string_with_formatting_args)]
for (platform, d) in &mut manifest.download_info { for (platform, d) in &mut manifest.download_info {
let template_url = d.url.take().unwrap().replace(version, "${version}"); let template_url = d.url.take().unwrap().replace(version, "${version}");
let template_bin = d.bin.take().map(|s| s.map(|s| s.replace(version, "${version}"))); let template_bin = d.bin.take().map(|s| s.map(|s| s.replace(version, "${version}")));
@@ -600,6 +602,7 @@ fn write_manifests(manifest_path: &Path, manifests: &Manifests) -> Result<()> {
Ok(()) Ok(())
} }
#[allow(clippy::literal_string_with_formatting_args)]
fn replace_vars( fn replace_vars(
s: &str, s: &str,
package: &str, package: &str,